search

quattor / configuration-modules-core

Node Configuration Manager Components for Everyone
www.quattor.org
Other
7 stars 56 forks source link

ncm-network: nmstate - add additional route rule parameters #1646

Closed aka7 closed 9 months ago

aka7 commented 10 months ago

provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes

Also add a default absent rule to clear route rules entries for the table. nmstate by default will merge rules therefore won't clear if there are any old rules already present. This will make sure only rules defined by profile is present.

ned21 commented 10 months ago

Thanks for making the changes. I see there's now a merge commit in the branch. Our preference is for a linear history: any chance you can use rebase to bring the branch up to date with main instead of merge?

aka7 commented 10 months ago

Thanks for making the changes. I see there's now a merge commit in the branch. Our preference is for a linear history: any chance you can use rebase to bring the branch up to date with main instead of merge?

ah sorry, that's my bad. wasn't meant push the merge commit out. This is another PR not yet merged but was just testing it again. so no rebase is needed at this point. fixed.

aka7 commented 9 months ago

closing PR in favor of one, https://github.com/quattor/configuration-modules-core/pull/1647