search

quattor / configuration-modules-core

Node Configuration Manager Components for Everyone
www.quattor.org
Other
6 stars 54 forks source link

ncm-altlogrotate: with only the global entry, and no entries marked as global, main configfifle is not edited #1657

Open stdweird opened 6 months ago

stdweird commented 6 months ago

issue is on L139

if (@globals) { -> if (@globals || $overallglobal) {

stdweird commented 6 months ago

@wdpypere this is the fix that is needed

stdweird commented 6 months ago

the main issue is the logic to ensure that global is the first element in @globals, but doing an unshift to add global, and a push for the the ones with global=true should also garantee that. it's a bit odd