quattor / configuration-modules-core

Node Configuration Manager Components for Everyone
www.quattor.org
Other
7 stars 56 forks source link

ncm-download 14.10.0-rc2: failing download.t on SL6 #372

Closed jouvin closed 9 years ago

jouvin commented 10 years ago

In 14.10.0-rc2 (https://github.com/quattor/release/issues/59), ncm-download fails unit test download.t on a SL6 machine with 14.10.0-rc2 installed.

I had a quick look but didn't find the reason... This is a minor issue, I set milestone to current release in case somebody has the time to look at it and find a trivial cause. Else can be postponed to 14.12, IMO.

stdweird commented 10 years ago

can't reproduce it. can you paste the output of

cd ncm-download
PERL5LIB=/usr/lib/perl QUATTOR_TEST_LOG_CMD_MISSING=1 QUATTOR_TEST_LOG_CMD=1 mvn clean test -Dunittest=download.t -Dprove.args='-v'

i get

[INFO] --- exec-maven-plugin:1.2:exec (pod2man) @ download ---
Generating man page from target/lib/perl/NCM/Component/download.pm
Creating man page for target/doc/pod/NCM/Component/download.pod, NCM::Component::download.8[INFO] 
[INFO] --- exec-maven-plugin:1.2:exec (prove) @ download ---
# execute command /usr/bin/curl -s -R -f --create-dirs -o target/test/file -m 1 file:///root/configuration-modules-core/ncm-download/target/test/source
src/test/perl/download.t .. 
updated target/test/source
ok 1 - Invocation with a too recent file succeeds
ok 2 - curl is not called if the remote file is too recent
ok 3 - Basic invocation succeeds
ok 4 - Curl command called as expected
ok 5 - Download of non-existing files fails
1..5
ok
All tests successful.
Files=1, Tests=5,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.30 cusr  0.09 csys =  0.43 CPU)
Result: PASS
[INFO] ------------------------------------------------------------------------
jouvin commented 9 years ago

I still have the issue and it would really help to get it fixed... Here is what I get:

[INFO] --- exec-maven-plugin:1.2:exec (pod2man) @ download ---
Generating man page from target/lib/perl/NCM/Component/download.pm
Creating man page for target/doc/pod/NCM/Component/download.pod, NCM::Component::download.8[INFO] 
[INFO] --- exec-maven-plugin:1.2:exec (prove) @ download ---
src/test/perl/00-load.t ..... ok

#   Failed test 'Curl command called as expected'
#   at src/test/perl/download.t line 75.
# Looks like you failed 1 test of 5.
src/test/perl/download.t .... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests 
src/test/perl/pod-syntax.t .. ok

This is on SL6.5.

stdweird commented 9 years ago

is this with the QUATTOR environment variables above? (the output should have a #execute command line). because it doesn't even print the tests (1..5) something is going horribly wrong. can you run ncm-ncd --co download on the node? maybe it will raise the error properly?

stdweird commented 9 years ago

or do a

perl -d:Trace `which prove` -I/usr/lib/perl -I./target/dependency/build-scripts/ -I./target/lib/perl/ -I./src/test/perl -r src/test/perl/download.t

(after a mvn clean test, so the target dir exists)

stdweird commented 9 years ago

hmm, that should be

PERL5LIB=/usr/lib/perl:./target/dependency/build-scripts:./target/lib/perl/:./src/test/perl perl -d:Trace src/test/perl/download.t

(not sure about the order in PERL5LIB)

jouvin commented 9 years ago

The error happens when running mvn test without anything special defined before...

jouvin commented 9 years ago

I ran the suggested Perl command. I have a very verbose output with the same error message in the middle of it... Do you want to see something particular?

stdweird commented 9 years ago

it should have the the calls that go wrong. gzip it and mail it, i can have a look.

jrha commented 9 years ago

@stdweird did you get anywhere?

jrha commented 9 years ago

Bumped to 15.2

jouvin commented 9 years ago

The problem is still there in 15.2.0-rc6 and prevents mvn test for the whole repo to run successfully.

stdweird commented 9 years ago

@jouvin can you me send the output of the following

cd ncm-download
QUATTOR_TEST_LOG_DEBUGLEVEL=5 QUATTOR_TEST_LOG_CMD_MISSING=1 QUATTOR_TEST_LOG_CMD=1 mvn clean test -Dunittest=download.t -Dprove.args='-v'

and the verbose perl Trace call

jouvin commented 9 years ago

This morning it works!!! In my previous test, I didn't execute the clean phase: may be something left from the previous version... I'm a bit surprised but I close this issue and will reopen it if it happens again.