search

quattor / configuration-modules-grid

Node Configuration Manager Components for Grid Middleware
www.quattor.org
Other
2 stars 14 forks source link

ncm-glitestartup: rpmlint fails on detected bash script #110

Closed stdweird closed 8 years ago

stdweird commented 8 years ago 
ncm-glitestartup.noarch: E: non-executable-script /usr/lib/ncm/config/glitestartup/gLite.template 0644L /bin/bash
stdweird commented 8 years ago

i've tagged this 16.6, if this harmless, can be moved to 16.8

jouvin commented 8 years ago

I'll try to look at it. gLite.template is, if I am right, the template for the init script.

jouvin commented 8 years ago

I had a look at this. In fact there is no way (at least I found none!) to tell rpmlint to ignore errors on some files. The only way to clear this error is to make this template executable which is a non sense... I tend to prefer keeping this error as expected in this particular case until we rewrite ncm-glitestartup without ncm-template.

stdweird commented 8 years ago

111 sort-of fixes it. it's not pretty, but neither is the the so-called template. it would be better if the init.d script was shipped as a script (and also not by a quattor component), and that the script does a

if [ -f /etc/sysconfig/giltestartup ]; then
    . /etc/sysconfig/giltestartup
fi

and that the component (or another component) generates the sysconfig file

jouvin commented 8 years ago

@stdweird Good suggestion, I opened #112.