search

quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

Test::Quattor::Critic: minimal critic version 1.118 (version provided by el7) #124

Closed stdweird closed 7 years ago

ned21 commented 7 years ago

Is the implication here that the unit tests can now only be run on an EL7 machine? Does that also mean that https://github.com/quattor/template-library-os/blob/sl6.x-x86_64/rpms/quattor-development.pan needs updating to include perl-critic?

stdweird commented 7 years ago

we'll need to rebuild the el7 perl-perl-critic rpm and add it to the externals repo

stdweird commented 7 years ago

building this version from cpan fails on el5 during build_all_repos, investigating...