search

quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

ProfileCache: prepare_profile_cache checks for valid object template #127

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

Depends on #125 Fixes #126

jouvin commented 7 years ago

Thanks for this. I have one minor comment: I think it'd be good to have a doc somewhere (can be on the web site and thus be done outside this PR) documenting how Perl::Critic::Policy::Quattor::UseCAFProcess is supposed to be used.

Also I'd suggest to change the title to something reflecting more the contents of the PR where the prepare_profile_cache() checks seem only one part of the PR...

stdweird commented 7 years ago

@jouvin wrt more code than title, this is based on #125. i'll rebase. wrt to using critic, once new maven tools are released, we can switch to tqu style testing, see eg https://github.com/quattor/CCM/pull/160, which includes critic.

stdweird commented 7 years ago

@jrha another one best included before new build-tools are released