search

quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

Test::Quattor::ProfileCache: use a ccm.cfg per compiled profile #148

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

Fixes #135 There is a bug in the way the unittests mock the Writer/Reader and how it used in ProfileCache and CCM. The main effect all but the first unittest do not use the default ccm.cfg, and in particluar, that tabcompletion is generated, which causes unnecessary slowdown.

stdweird commented 7 years ago

I plan to backport this on jenkins to 1.50/51/52, to check speed-up of the unit tests of the components

ned21 commented 7 years ago

@stdweird The description of the problem being fixed here in the PR is great but it would be even better if it was in the commit log itself in case we ever move away from GH and lose access to the PR data.

stdweird commented 7 years ago

@ned21 added it to the commit message