Mocked FileWriter: set noaction=1 by default

[jouvin]

Also:

• Remove make_directory() from simple_caf module as it is part of Test/Quattor.pm with a different interface
• Update directory() from Test/Quattor.pm to return a dualvar as the standard CAF::Path::directory()
• Update unit tests accordingly

Fixes #139.

[jouvin]

Has been verified to properly work with CAF.

[jouvin]

Test is failing because I missed a problem when I ran the test locally as I tend not to run the mvn clean: the compilation of the profile (with use Test::Quattor qw(quattor)) seems to use the mocked FileWriter/Editor that has now noaction set by default instead of using the unmocked FileWriter... I have not been able to figure out where this is done. @stdweird any hint?

[stdweird]

@jouvin i'm trying to make the unittests of the ncm-network cleanup adhere to proper NoAction usage (by setting $Test::Quattor::NoAction=1), but i'm running in a lot of small mostly unrelated problems. this needs more testing first.

[jouvin]

@stdweird sure it needs to be tested with the various pieces. I think that if we manage to do it, at the end the test framework will be cleaner as there will really be no need to have CAF::Object::NoAction=1 defined in so many places...

[jouvin]

Problem mentioned in https://github.com/quattor/maven-tools/pull/150#issuecomment-290168019 fixed. Should be ready for testing with other Quattor components now...

[stdweird]

@jouvin i'm adapting and cleaning up the test framework for this case. it's a lot more complicated than this patch, but the new FileWriter allows for cleaner/fewer code, so i'd prefer not to merge this yet. i'll also try to clarify the make_directory issue in the PR.

[jouvin]

No problem, I always had in mind that this PR required careful evaluation and testing...

[jrha]

@jouvin if you have time could you rebase and resolve the conflicts?

[stdweird]

@jrha @jouvin unless i'm mistake, this PR was replaced by #160

[jrha]

It does indeed seem that way.