Closed stdweird closed 7 years ago
@stdweird from what I understand, this PR replaces #150. In this case, you should mention it in the description and close #150.
@jouvin i tried to improve the explanation a bit
@stdweird have you done it already or do you plan to do it?
@jouvin for got to push force, should be ok now
@stdweird is this required to be in the next release of the build tools?
@jrha yes. this PR contains the required cleanup and fixes for the new new FileWriter.
Thanks, could you respond to @jouvin's comment?
@jouvin are you happy with this now?
@jrha @jouvin i can fix the issues thursday, probably not sooner
Ok, no worries.
@jrha that simpler than i tought. should be ok now
Thanks! @jouvin, can you update your review?
this removes the
set_caf_file_close_diff
function. it is now default and "just works".Replaces #150, fixes #139.