quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

Test::Quattor: set $Test::Quattor::NoAction default to 1 #160

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

this removes the set_caf_file_close_diff function. it is now default and "just works".

Replaces #150, fixes #139.

jouvin commented 7 years ago

@stdweird from what I understand, this PR replaces #150. In this case, you should mention it in the description and close #150.

stdweird commented 7 years ago

@jouvin i tried to improve the explanation a bit

jouvin commented 7 years ago

@stdweird have you done it already or do you plan to do it?

stdweird commented 7 years ago

@jouvin for got to push force, should be ok now

jrha commented 7 years ago

@stdweird is this required to be in the next release of the build tools?

stdweird commented 7 years ago

@jrha yes. this PR contains the required cleanup and fixes for the new new FileWriter.

jrha commented 7 years ago

Thanks, could you respond to @jouvin's comment?

jrha commented 7 years ago

@jouvin are you happy with this now?

stdweird commented 7 years ago

@jrha @jouvin i can fix the issues thursday, probably not sooner

jrha commented 7 years ago

Ok, no worries.

stdweird commented 7 years ago

@jrha that simpler than i tought. should be ok now

jrha commented 7 years ago

Thanks! @jouvin, can you update your review?