quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

ProfileCache: use compiled profile directly instead of downloading #167

Closed stdweird closed 6 years ago

stdweird commented 6 years ago

@jrha this reduces the output in verbose mode of the unittests a lot. how long would it take to make an 1.56 release?

jrha commented 6 years ago

Not particularly long, but would require current masters to pass tests. Last night's CentOS 6 & 7 builds failed on the same problem:

CentOS 6: MVN E: # Failed test 'Same file, same data, so contents not changed, NoAction set'
CentOS 6: MVN E: # at src/test/perl/quattor_mock.t line 39.
CentOS 6: MVN E: # Failed test 'no diff on FileEditor open/close'
CentOS 6: MVN E: # at src/test/perl/quattor_mock.t line 78.

CentOS 7: MVN E: # Failed test 'Same file, same data, so contents not changed, NoAction set'
CentOS 7: MVN E: # at src/test/perl/quattor_mock.t line 39.
CentOS 7: MVN E: # Failed test 'no diff on FileEditor open/close'
CentOS 7: MVN E: # at src/test/perl/quattor_mock.t line 78.
stdweird commented 6 years ago

@jrha what CAF version is used for those?

jrha commented 6 years ago

It's just build_all_repos ... so master?

Full log is here: https://github.com/quattor/release/releases/download/nightly_2017-12-06T14/build.log.gz

stdweird commented 6 years ago

ah, ok. i'll have a look

jrha commented 6 years ago

Thanks

stdweird commented 6 years ago

can you confirm that these hosts have selinux enabled? that's the only thing i can see from the logs that might be relevant

stdweird commented 6 years ago

ok, the jenkins master builds were not triggered in months, ie all unittests run with 17.3 (incl caf and ccm)

stdweird commented 6 years ago

retest this please

stdweird commented 6 years ago

@jrha ok, jenkins fails again

jrha commented 6 years ago

Eew, thanks for working out what happened.

stdweird commented 6 years ago

@jrha jenkins issue understood, waiting for merge to see it in action

stdweird commented 6 years ago

i can reproduce it locally, i was missing https://github.com/quattor/CAF/pull/262 in my local install

stdweird commented 6 years ago

@jrha last commits needs unittests and testing on all other repos, but it's the culprit

stdweird commented 6 years ago

@jrha unittests added. this is very likely to become 1.56. i'm going to test this on the repos now

stdweird commented 6 years ago

looks ok for caf, ccm, ncm-ncd aii gives a failing test due to some spurious reporting, will be fix when bumping to 1.56 i have not tried any components yet, but i feel confident (or lucky 😄

jrha commented 6 years ago

Looking good, let me know when you are happy for this to be merged.

jrha commented 6 years ago

In the mean time I'll try to put together an environment when I can produce a new release of the build tools.

stdweird commented 6 years ago

@jrha i'm happy

jrha commented 6 years ago

@stdweird 1.56 released, should show up on Nexus at some point today.