quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
4 stars 13 forks source link

Support template unittesting through controlled failure of compilations #42

Closed stdweird closed 9 years ago

stdweird commented 9 years ago

Support controlled pan compilation failure through ProfileCache prepare_profile_cache method. This allows unittesting of failing pan templates (eg to unittest intentional compilation failures due to schema violation).

hpcugentbot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/maven-tools-pr-builder/14/ Test PASSed.

hpcugentbot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/maven-tools-pr-builder/15/ Test PASSed.

stdweird commented 9 years ago

@jrha i think last commit closes another (hopefully last) possible path that can lead to a racecondition and the DESTROY failures of the unittests

stdweird commented 9 years ago

retest this please

stdweird commented 9 years ago

test this please

hpcugentbot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/maven-tools-pr-builder/17/ Test FAILed.

stdweird commented 9 years ago

test this please

hpcugentbot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/maven-tools-pr-builder/18/ Test PASSed.

jrha commented 9 years ago

@stdweird — I'm happy to merge this when the PR has a suitable bit of text explaining what this is and why it's needed. :smile_cat:

stdweird commented 9 years ago

@jrha i thought the original "Text explaining what this means goes here." was clear enough :smile:

jrha commented 9 years ago

Thanks. Does this also fix quattor/configuration-modules-core#432?

stdweird commented 9 years ago

@jrha remains to be seen, but very likely.

jrha commented 9 years ago

Ok cool

jouvin commented 9 years ago

I propose to merge this PR now in order to produce a new release. @jhra, anything against merging?