search

quattor / maven-tools

Maven-based Build Tools
www.quattor.org
Apache License 2.0
3 stars 12 forks source link

Rename Test::Quattor::TextRender::Base mock method to mock_textrender #57

Closed stdweird closed 9 years ago

stdweird commented 9 years ago

Unittest will fail, but fix should be as simple as changing

use Test::Quattor::TextRender::Base;
mock();

to 

use Test::Quattor::TextRender::Base;
mock_textrender();
hpcugentbot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): https://jenkins1.ugent.be/job/maven-tools-pr-builder/52/ Test PASSed (test).

stdweird commented 9 years ago

should never have made it in master like this, even i start to find the name confusing :smile:

ned21 commented 9 years ago

Unittest will fail

So is this safe to merge?

stdweird commented 9 years ago

@ned21 yes, only after the release is published and build tools bumped in the pom, some tests will fail, and this is how to fix them.