search

quattor / ncm-cdispd

Node Configuration Manager Configuration Dispatch Daemon
www.quattor.org
Other
2 stars 5 forks source link

configuration changes with non-existing path #39

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

currently, the changed_CPE code treats a missing CPE path in the new config sometimes as an error and returns nothing has changed.

i would propose that the check for non-existing paths in the new config is performed first.

this would introduce possible backwards incompatible behaviour, but would remove any randomness. currenlty, non-existing CPEs should be very rare hard when the component type is used, but not impossible (eg removing the component package from /software/packages, and running without the noautoregpkg is sufficient)

jouvin commented 7 years ago

change_CPE return value is not a status code but a boolean saying if ncm-ncd needs to dispatch this component... change_CPE currently considers nothing as an error...