search

quattor / ncm-cdispd

Node Configuration Manager Configuration Dispatch Daemon
www.quattor.org
Other
2 stars 5 forks source link

ncm-cdispd: report sleep when no updated profile found with debug 1 #46

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

Fixes #45

stdweird commented 7 years ago

Untested

ned21 commented 7 years ago

LGTM. Any volunteers to test it? Is this a blocker for 16.10?

jouvin commented 7 years ago

Yes, this is an almost-blocker, see #45. You can fill up your log very quickly... I tested it and it works exactly as expected. Here is the output with this patch from ncm-cdispd.log:

2016/11/07-14:08:15 [INFO] ncm-ncd finished with status: 0 (ec 0, all configuration modules ran successfully)

2016/11/07-14:12:15 [INFO] new profile arrived, examining...
updated /var/lib/ccm/profile.22/ccm-active-profile.22-636045
2016/11/07-14:12:15 [VERB] new profile detected: cid=22
2016/11/07-14:12:15 [INFO] new profile has same checksum as old one, no NCM run

Without the patch you'll have got 3 (useless) lines no new profile found, sleeping between the end of the ncm-ncd run and the detection of the new profile.

I am in favor of merging this PR.

ned21 commented 7 years ago

@jouvin Cool - please go ahead and merge!