No tests - Githubissues

quattor / ncm-cdispd

Node Configuration Manager Configuration Dispatch Daemon

www.quattor.org

Other

2 stars 5 forks source link

No tests #7

Closed jrha closed 10 years ago

jrha commented 10 years ago

It would be lovely to have something that we could run as a test to make sure we haven't broken ncm-cdispd, unit tests would be wonderful, but anything would be better than nothing.

jouvin commented 10 years ago

I completely agree but I'm afraid unfortunately this is difficult to implement with the code as it it is today... Most of the work happen in the "event loop" (appearance of a new profile) that is difficult to test in unit tests. I'm happy to receive any suggestion!

jrha commented 10 years ago

I know, it's a long term wish perhaps.

jouvin commented 10 years ago

I thinked about this issue and my proposal would be to split ncm-cdispdin 2 parts:

The current main() would remain /usr/sbin/ncm-cdispd and remain untestable (an infinite loop, main thing to test is the behaviour with respect to ncm-ncd status, something difficult to emulate...)
All the other functions becoming a Perl module in /usr/lib/perl/NCM and thus eligible to unit testing.

Is this proposal sensible? @piojo and other Perl gurus, what do you think?

If agreed, could be implemented as part of #9.

jouvin commented 10 years ago

See https://github.com/quattor/ncm-cdispd/issues/8#issuecomment-49561541 for the current plan.