Consider validation of '/system/archetype/os/name'

quattor / template-library-core

Pan templates for the configuration modules

Apache License 2.0

3 stars 28 forks source link

Consider validation of '/system/archetype/os/name' #178

Open jrha opened 6 years ago

jrha commented 6 years ago

As mentioned in quattor/configuration-modules-core#1282.

For:

We are relying upon it in components, so we should be able to control the contents.

Against:

The broker will accept almost anything, it may be some time after the OS is added to the broker before the validation is hit at compile time, this could be painful.

ned21 commented 6 years ago

Another potential challenge: t's used in different ways at different sites. So e.g. we use it for Linux/Solaris but in @jouvin's setup docs he uses it to differentiate between Linux distros.

jrha commented 6 years ago

Perhaps the validation should be nothing more than "is a complete lower-case word with no funny characters"

jrha commented 6 years ago

One of the types in #180 perhaps?

jouvin commented 6 years ago

I think that if we want to be able to test against it in other standard templates, it would be better to have an exhaustive list of possible values. Is it really much more than linux, centos, scientific-linux, rhel, debian, ubuntu? It looks to me as a rather finite list that we can update when needed...

jrha commented 1 year ago

I don't think we can meaningfully validate the content in any other way than enforcing a lowercase string_trimmed.