Closed maxeem closed 2 months ago
Why not fix get_num_of_cores_max_threads
to handle max_threads
being undefined?
In addition to templates changes? Or keeping old templates as they are?
I can make it default to cores count when needed, but some people might end up having less thread count by default.. which is not too bad but probably not optimal 🤷♂️
Yep, in addition to this change (which is fine in itself), but the schema doesn't enforce the property being present, so get_num_of_cores_max_threads
shouldn't rely on it.
Rebased.
This was needed to avoid hitting a bug when using the get_num_of_max_threads() function.
This assumes that hyperthreading is enabled.
For CPUs that do not support hyperthreading it sets max_threads to the value of cores count.