clairctl: warn when range requests are not honored

quay / clair

Vulnerability Static Analysis for Containers

https://quay.github.io/clair/

Apache License 2.0

10.36k stars 1.16k forks source link

clairctl: warn when range requests are not honored #2031

Closed freedge closed 7 months ago

freedge commented 7 months ago

As discussed in https://github.com/quay/clair/issues/2029 the manifest generation is efficient only when HTTP "Range: bytes=0-0" header is well supported by the server. If not, the server might return the full layer, making the manifest generation very expensive.

We warn the user in case their HTTP server does not support HTTP range requests.

app-sre-bot commented 7 months ago

Can one of the admins verify this patch?

hdonnay commented 7 months ago

LGTM, will rebase and merge.

hdonnay commented 7 months ago

Weird that there's a permissions issue on the approval comment fast-forward...

/fast-forward