quay / quay-bridge-operator

Utilization of Red Hat Quay as the default image registry for an OpenShift Container Platform environment
Apache License 2.0
20 stars 23 forks source link

chore: Bump dependencies (PROJQUAY-4892) #60

Closed dmage closed 1 year ago

dmage commented 1 year ago

/cherrypick redhat-3.9 /cherrypick redhat-3.8

openshift-cherrypick-robot commented 1 year ago

@dmage: once the present PR merges, I will cherry-pick it on top of redhat-3.9 in a new PR and assign it to you.

In response to [this](https://github.com/quay/quay-bridge-operator/pull/60#issuecomment-1607799300): >/cherrypick redhat-3.9 >/cherrypick redhat-3.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 1 year ago

/cherrypick redhat-3.8

openshift-cherrypick-robot commented 1 year ago

@dmage: once the present PR merges, I will cherry-pick it on top of redhat-3.8 in a new PR and assign it to you.

In response to [this](https://github.com/quay/quay-bridge-operator/pull/60#issuecomment-1607801135): >/cherrypick redhat-3.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 1 year ago

/retest

dmage commented 1 year ago

/retest

dmage commented 1 year ago

/retest

dmage commented 1 year ago

@flavianmissi @jonathankingfc please review the commit https://github.com/quay/quay-bridge-operator/pull/60/commits/1c9cd4125bc781303e5841bfbf61bb404cbfd576. Operator logs without this commit - https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/quay_quay-bridge-operator/60/pull-ci-quay-quay-bridge-operator-master-ocp-latest-e2e/1673356275993284608/artifacts/e2e/gather-extra/artifacts/pods/oo-z8q4l_quay-bridge-operator-6b96c9dd76-ch77h_manager.log

flavianmissi commented 1 year ago

/lgtm

unrelated question: there are some references to 4.6 in the tests, do we need them? OCP 4.6 is EOL

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi, HammerMeetNail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/quay/quay-bridge-operator/blob/master/OWNERS)~~ [dmage,flavianmissi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 year ago

@dmage: new pull request created: #61

In response to [this](https://github.com/quay/quay-bridge-operator/pull/60#issuecomment-1607801135): >/cherrypick redhat-3.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@dmage: new pull request created: #62

In response to [this](https://github.com/quay/quay-bridge-operator/pull/60#issuecomment-1607799300): >/cherrypick redhat-3.9 >/cherrypick redhat-3.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 1 year ago

@flavianmissi we don't; I was pleasantly surprised that everything still works on 4.6 :) We need to use 4.10 as the lower bound.

dmage commented 1 year ago

https://github.com/openshift/release/pull/40693 will bump minimal OCP