Closed dmage closed 1 year ago
@dmage: once the present PR merges, I will cherry-pick it on top of redhat-3.9 in a new PR and assign it to you.
/cherrypick redhat-3.8
@dmage: once the present PR merges, I will cherry-pick it on top of redhat-3.8 in a new PR and assign it to you.
/retest
/retest
/retest
@flavianmissi @jonathankingfc please review the commit https://github.com/quay/quay-bridge-operator/pull/60/commits/1c9cd4125bc781303e5841bfbf61bb404cbfd576. Operator logs without this commit - https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/quay_quay-bridge-operator/60/pull-ci-quay-quay-bridge-operator-master-ocp-latest-e2e/1673356275993284608/artifacts/e2e/gather-extra/artifacts/pods/oo-z8q4l_quay-bridge-operator-6b96c9dd76-ch77h_manager.log
/lgtm
unrelated question: there are some references to 4.6 in the tests, do we need them? OCP 4.6 is EOL
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dmage, flavianmissi, HammerMeetNail
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@dmage: new pull request created: #61
@dmage: new pull request created: #62
@flavianmissi we don't; I was pleasantly surprised that everything still works on 4.6 :) We need to use 4.10 as the lower bound.
https://github.com/openshift/release/pull/40693 will bump minimal OCP
/cherrypick redhat-3.9 /cherrypick redhat-3.8