qubeshub / hubzero-cms

HubZero CMS code base for QUBESHub.
https://qubeshub.org
GNU General Public License v2.0
0 stars 1 forks source link

Improve contrast ratio throughout site #190

Closed mdlama closed 3 years ago

mdlama commented 5 years ago

This seems to me a persistent issue on our site that we could address fairly easily. Here's an example of an issue right now:

Screen Shot 2019-04-06 at 11 50 57 AM

Essentially, all links are not meeting the WCAG criteria!! Here's a useful tool:

https://webaim.org/resources/contrastchecker/

mdlama commented 5 years ago

Here's another example with buttons:

Screen Shot 2019-04-06 at 12 22 14 PM
trisketz commented 5 years ago

Big question - that color green has been a part of QUBES template colors I think since the beginning. Are we willing to change this?

mdlama commented 5 years ago

I would say yes, we should reconsider the color. Keep it close, but I think accessibility is more important.

On Apr 7, 2019, at 2:11 PM, Jenny notifications@github.com wrote:

Big question - that color green has been a part of QUBES template colors I think since the beginning. Are we willing to change this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qubeshub/hubzero-cms/issues/190#issuecomment-480615591, or mute the thread https://github.com/notifications/unsubscribe-auth/AEpsAzjORNaPFRiCI9w7R0PNPeTK6bTgks5vejS-gaJpZM4cgRfT.

trisketz commented 5 years ago

I should add about the latest pull #216. There is one place I wasn't sure how to remove the underline link. Under the publication record view - under group ownership. The image has the underline and when you hover over, the link will have bad contrast as well as the underline. The CSS that is being pulled for that section is from: /core/plugins/publications/groups/assets/css/groups.css

Screen Shot 2019-07-24 at 1 17 21 PM Screen Shot 2019-07-24 at 1 17 29 PM

mdlama commented 5 years ago

I think we can override the groups.css file in that plugin by creating the following file

/app/templates/bmc/html/plg_publications_groups/groups.css

which can then have the following at the top of the file:

@import url('/core/plugins/publications/groups/assets/css/groups.css');

Would that help?

trisketz commented 5 years ago

I think that would, that sounds simple enough. I thought there was going to have to be some complicated process to create an override.

On Wed, Jul 24, 2019 at 2:03 PM M. Drew LaMar notifications@github.com wrote:

I think we can override the groups.css file in that plugin by creating the following file

/app/templates/bmc/html/plg_publications_groups/groups.css

which can then have the following at the top of the file:

@import url('/core/plugins/publications/groups/assets/css/groups.css');

Would that help?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/qubeshub/hubzero-cms/issues/190?email_source=notifications&email_token=AFHSJBORGXZRLOPDVGKVNB3QBCYSFA5CNFSM4HEBC7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XOQQY#issuecomment-514779203, or mute the thread https://github.com/notifications/unsubscribe-auth/AFHSJBKAJ4TKRJMZUAMIHVLQBCYSFANCNFSM4HEBC7JQ .

trisketz commented 5 years ago

Override has been created and I went ahead and fixed the links on the pub record view.

mdlama commented 5 years ago

Hi, Jenny. Here's a picture of the Support system after the code push.

Screen Shot 2019-07-30 at 2 35 59 PM

Can we override it so that the summary text isn't bold and underlined?

trisketz commented 5 years ago

I also want to adjust the font on our publications macro, as well as add a border around the images. But I can't get the macro to work on my vagrant at the moment.

trisketz commented 5 years ago

Okie dokie. Getting rid of the underline for links update:

Screen Shot 2019-10-18 at 3 43 38 PM Screen Shot 2019-10-18 at 3 43 55 PM Screen Shot 2019-10-18 at 3 44 24 PM