BharathR8
commented
5 years ago Alright. Thanks for the clarification.
Regards, Bharath Chandra Reddy Barakam
On Thu, 2 May 2019 at 09:15, M. Drew LaMar notifications@github.com wrote:
@mdlama commented on this pull request.
In app/plugins/content/qubesmacros/migrations/Migration20190429000000PlgContentQubesmacros.php https://github.com/qubeshub/hubzero-cms/pull/198#discussion_r280412145:
@@ -8,7 +8,7 @@ /**
- Migration script for adding Content - QUBES Macros **/ -class Migration20180530000000PlgContentQubesmacros extends Base +class Migration20190429000000PlgContentQubesmacros extends Base
Heads up, Bharath: we don't need to change the date of the migration script for every new item or edit to the extension.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/qubeshub/hubzero-cms/pull/198#pullrequestreview-232998093, or mute the thread https://github.com/notifications/unsubscribe-auth/AGJNT5GNQTCC4Y5QUCSPPRTPTLSPDANCNFSM4HJXSTQQ .
mdlama
[code] Added functionality to the carousel.php file to adjust height, width and timeout duration. [code] Added functionality to the carousel.php file to render images from a directory, if a directory is taken as the input argument. [code] Also added functionality to check if a given file is an image in a directory and only render it if it's an image. [refactor] Renamed the file names from 'slider' to 'carousel'.