search

qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
182 stars 74 forks source link

Move from 4-space to 2-space indents #105

Closed jordanw-bq closed 6 years ago

jordanw-bq commented 6 years ago

Most open-source project use 2-space indents for their source files. We want to use this for RubiX as well.

jordanw-bq commented 6 years ago

This will include updating our Checkstyle checks.xml to enforce indenting.

abhishekdas99 commented 6 years ago

As part of this we are going to update the checkstyle and fix all the errors coming because of the change

abhishekdas99 commented 6 years ago

https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

jordanw-bq commented 6 years ago

@abhishekdas99 To confirm, will we be completely switching to Google's checks?

abhishekdas99 commented 6 years ago

@stagraqubole was referring to airlift (facebook) code style. We can pick either of them. My preference is to have 2-space indents rather than 4 space indents.