search

qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
183 stars 74 forks source link

fix: usr: ISS-141: Throwing exception only when none of the parent directories exists #142

Closed abhishekdas99 closed 6 years ago

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 96

Totals Coverage Status
Change from base Build 87: 0.07%
Covered Lines: 533
Relevant Lines: 2151
💛 - Coveralls
vrajat commented 6 years ago

I am assuming this is a regression from a refactor. @jordanw-bq / @abhishekdas99 Can one of you also add a unit test ? Or do we need product tests to test these. If yes, can you please file a new issue and label it as product-test (create a new one if required).

jordanw-bq commented 6 years ago

Since I don't have permissions to push to the branch to update this PR, here is a .patch file containing the changes: cacheDirUnitTest.txt (GitHub only accepts certain file formats, so I've changed the extension)

vrajat commented 6 years ago

@jordanw-bq Can you open a new pull request ?

vrajat commented 6 years ago

@abhishekdas99 Is this scenario already covered by the test in TestCacheUtil ?

abhishekdas99 commented 6 years ago

Added unit tests.