qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
183 stars 74 forks source link

chg: dev: #153: report additional metrics from worker nodes #161

Closed jordanw-bq closed 6 years ago

jordanw-bq commented 6 years ago
coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 209


Changes Missing Coverage Covered Lines Changed/Added Lines %
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/WorkerBookKeeper.java 0 1 0.0%
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeperServer.java 0 2 0.0%
rubix-core/src/main/java/com/qubole/rubix/core/utils/ClusterUtil.java 11 13 84.62%
rubix-spi/src/main/java/com/qubole/rubix/spi/ClusterType.java 0 3 0.0%
rubix-spi/src/main/java/com/qubole/rubix/spi/CacheConfig.java 0 4 0.0%
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/utils/DiskUtils.java 0 9 0.0%
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeper.java 0 38 0.0%
<!-- Total: 12 71 16.9% -->
Files with Coverage Reduction New Missed Lines %
rubix-spi/src/main/java/com/qubole/rubix/spi/CacheConfig.java 1 25.21%
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeperServer.java 2 0.0%
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeper.java 2 0.0%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 206: -0.1%
Covered Lines: 582
Relevant Lines: 2470

💛 - Coveralls
jordanw-bq commented 6 years ago

@abhishekdas99 I addressed your code review comments. Currently working on cluster testing for the new cache size metric impl

jordanw-bq commented 6 years ago

@abhishekdas99 Passed cluster testing

jordanw-bq commented 6 years ago

@abhishekdas99 The cache size metric is currently reporting the total number of bytes cached, which could become a fairly high number. I'm thinking of changing it to MB instead to make it more readable. Thoughts?

abhishekdas99 commented 6 years ago

@jordanw-bq We should report the cache size in MB