qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
183 stars 74 forks source link

Changes made for Continuous Integration process with docker in Travis #181

Closed kvankayala closed 6 years ago

kvankayala commented 6 years ago

Changed .travis.yml file Added script.sh Uses docker image "kvankayala/hadoop_mvn_thrift" for Continuous Integration.

vrajat commented 6 years ago

Nice! I could see the testng o/p in travis. I have a few high level questions:

kvankayala commented 6 years ago

@vrajat 1) I will add the cobertura to travis.yml 2) a. Both #166 and #181 are interdependent on each other i.e., #166 validates changes in #181 and vice-versa. b. Plan is first merge #181 which provides infrastructure (docker) to validate tests in #166. c. Otherwise, I can push #166 changes with #181 in a temporary commit (will remove #166 changes after validation) and validate both together and later approves them separately. 3) Yes, it could be done. But, this docker container has all the necessary dependencies for rubix testing. So, it is better to execute all the tests together in Docker. 4) I could explore about this. Currently, I feel that maven dependencies download could be avoided in docker. But, We would like to leave it for improvements once this initial jvm and docker stuff works good. 5) I will move the container to quboleinc

abhishekdas99 commented 6 years ago

Lets add the DOCKERFILE in the repo for the sake of completeness.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 224


Totals Coverage Status
Change from base Build 211: 0.0%
Covered Lines: 582
Relevant Lines: 2470

💛 - Coveralls