qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
183 stars 74 forks source link

Move Rubix Thrift classes to separate package #185

Closed jordanw-bq closed 6 years ago

jordanw-bq commented 6 years ago

Currently, generated Thrift classes need to be explicitly excluded from the Cobertura coverage plugin; otherwise the Coveralls plugin will report an error when it tries to find the class.

Example: [ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project rubix-root: I/O operation failed: No source found for com/qubole/rubix/spi/FileInfo.java -> [Help 1]

We cannot exclude the package these generated files are found in, since this is the same package as the other rubix-spi classes; however, this brings the maintenance cost of having to remember to add a new exclusion each time we add a Thrift class.

If the Thrift classes were moved to a subpackage, we could exclude the entire subpackage and prevent having to update the exclusions for each new Thrift class.