search

qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
183 stars 74 forks source link

chg: usr: #307: add configuration option for server socket timeout #308

Closed jordanw-bq closed 5 years ago

jordanw-bq commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #308 into master will increase coverage by 0.8%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #308     +/-   ##
=========================================
+ Coverage   50.36%   51.17%   +0.8%     
=========================================
  Files          60       60             
  Lines        3036     3029      -7     
  Branches      334      334             
=========================================
+ Hits         1529     1550     +21     
+ Misses       1418     1388     -30     
- Partials       89       91      +2
Impacted Files Coverage Δ
...n/java/com/qubole/rubix/spi/BookKeeperFactory.java 60% <100%> (+60%) :arrow_up:
...rc/main/java/com/qubole/rubix/spi/CacheConfig.java 25% <100%> (+4.47%) :arrow_up:
...qubole/rubix/bookkeeper/CoordinatorBookKeeper.java 87.17% <0%> (-2.57%) :arrow_down:
.../com/qubole/rubix/core/RemoteReadRequestChain.java 71.13% <0%> (ø) :arrow_up:
.../com/qubole/rubix/core/CachedReadRequestChain.java 81% <0%> (ø) :arrow_up:
...java/com/qubole/rubix/core/CachingInputStream.java 0% <0%> (ø) :arrow_up:
...com/qubole/rubix/spi/RetryingBookkeeperClient.java 15.62% <0%> (+15.62%) :arrow_up:
abhishekdas99 commented 5 years ago

@jordanw-bq Is it possible to add couple of simple unit tests covering the cases where you are getting a timeout and not getting a timeout exception.