qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
182 stars 74 forks source link

Refactor code to remove default constructor of RetryingPooledBookkeeperClient #353

Open shubhamtagra opened 4 years ago

shubhamtagra commented 4 years ago

Default constructor of RetryingPooledBookkeeperClient exists because LoocalBookkeerClient extends RetryingPooledBookkeeperClient which is done because we use RetryingPooledBookkeeperClient object everywhere in the code hence to fit in LoocalBookkeerClient we need it to be extending RetryingPooledBookkeeperClient.

Instead, we should be reference RetryingPooledBookkeeperClient objects via BookKeeperService.Iface to keep implementations open.