search

qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
182 stars 74 forks source link

Avoid caching presto worker nodes #465

Closed JamesRTaylor closed 3 years ago

JamesRTaylor commented 4 years ago

@stagraqubole - not sure about the test integration failure.

JamesRTaylor commented 3 years ago

@shubhamtagra - I can put this change behind a config flag so that it maintains the current implementation if you're worried about it. We'd really like to have this capability it in the next release to test out in conjunction with your other fixes.

JamesRTaylor commented 3 years ago

WDYT @shubhamtagra?

JamesRTaylor commented 3 years ago

@shubhamtagra - I've updated the PR as we've discussed. Please review when you have a chance.

JamesRTaylor commented 3 years ago

To use SyncPrestoCM, you plan to use rubix.cluster.manager.presto.class config?

Yes, exactly.

Would it be possible to get a new version of rubix with this change in it?

Thanks again for the code reviews.

shubhamtagra commented 3 years ago

Merged, thanks @JamesRTaylor. I will release a new version so that this could be picked up in Presto.