search

qubole / rubix

Cache File System optimized for columnar formats and object stores
Apache License 2.0
182 stars 74 forks source link

Use NodeManager to get current host name and address for prestosql #471

Closed JamesRTaylor closed 3 years ago

JamesRTaylor commented 3 years ago

Here's a fix for prestosql 0.3.19 problem, @shubhamtagra.

JamesRTaylor commented 3 years ago

@shubhamtagra - sorry for the trouble, but would it be possible to get a new rubix release with this fix in it? cc @harmandeeps

shubhamtagra commented 3 years ago

@JamesRTaylor This part gets missed out in testing. It was added when you saw that right hostname was not getting picked in your setup. The code lgtm, can you please also add a simple UT which checks that expected hostname is returned by the PrestoCM. Post that, I will make a release right after merging.

JamesRTaylor commented 3 years ago

I've added the test, @shubhamtagra. Thanks for the reviews.

shubhamtagra commented 3 years ago

Thanks, merged.

0.3.20 has been released.