Closed abhishekdas99 closed 6 years ago
We are planning to use 2 space indent. We have to go back and change the indent from 4 space to 2 space of the older files.
We should also write a script to get the collated view of these metrics across the cluster. Presto provides extracting jvm metrics from all nodes and show them in a single view which makes it easier to track these metrics, something similar for bookkeeper metrics would be really helpful
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
rubix-common/src/main/java/com/qubole/rubix/common/MetricsConstant.java | 0 | 2 | 0.0% | ||
rubix-common/src/main/java/com/qubole/rubix/common/MetricsReporting.java | 0 | 3 | 0.0% | ||
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/FileMetadata.java | 0 | 6 | 0.0% | ||
rubix-common/src/main/java/com/qubole/rubix/common/DummyMetrics.java | 0 | 7 | 0.0% | ||
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeperServer.java | 0 | 12 | 0.0% | ||
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeper.java | 0 | 14 | 0.0% | ||
rubix-common/src/main/java/com/qubole/rubix/common/MetricsFactory.java | 0 | 14 | 0.0% | ||
rubix-common/src/main/java/com/qubole/rubix/common/CodahaleMetrics.java | 0 | 80 | 0.0% | ||
<!-- | Total: | 0 | 138 | 0.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeper.java | 1 | 0.0% | ||
rubix-bookkeeper/src/main/java/com/qubole/rubix/bookkeeper/BookKeeperServer.java | 1 | 0.0% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 36: | -1.6% |
Covered Lines: | 288 |
Relevant Lines: | 1655 |
Superseded by a separate design.
The new classes being added here only have a 2 space indent. We should match the indentation of the rest of the project (4 spaces)