search

quchen / prettyprinter

A modern, extensible and well-documented prettyprinter.
BSD 2-Clause "Simplified" License
293 stars 34 forks source link

Re-export pack, unpack and Text from Data.Text #208

Open newhoggy opened 2 years ago

newhoggy commented 2 years ago

Re-export some Data.Text modules for the purpose of downstream libraries being able to write code compatible with the fake text module

Related issue: https://github.com/quchen/prettyprinter/issues/207

newhoggy commented 2 years ago

I've adopted the recommendations in https://github.com/quchen/prettyprinter/issues/207#issuecomment-927905099

sjakobi commented 2 years ago

Please ignore the CI failure BTW. It's probably related to https://gitlab.haskell.org/haskell/ghcup-hs/-/issues/123.

sjakobi commented 2 years ago

CI on master should be fixed now. Please rebase!

newhoggy commented 2 years ago

The workflow for this PR is not running, but I've verified it builds independently here: https://github.com/input-output-hk/prettyprinter/pull/1

newhoggy commented 2 years ago

Added explicit export list and updated the docs "or" -> "and".

newhoggy commented 2 years ago

I've pushed the requested updates.

newhoggy commented 2 years ago

Will we be able to merge this?

sjakobi commented 2 years ago

Ping, @quchen!