search

qucontrol / krotov

Python implementation of Krotov's method for quantum optimal control
https://qucontrol.github.io/krotov
Other
70 stars 29 forks source link

Use "safe" discretization via midpoints #75

Closed goerz closed 4 years ago

goerz commented 4 years ago

Closes #74

goerz commented 4 years ago

@zachmanson You should now be getting notifications on this

goerz commented 4 years ago

@zachmanson This is now ready. Let me know if you want to review/test this. Otherwise, I'll merge this branch and put out a new release for krotov soon.

codecov[bot] commented 4 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   95.99%   96.12%   +0.13%     
==========================================
  Files          13       13              
  Lines        1671     1677       +6     
==========================================
+ Hits         1604     1612       +8     
+ Misses         67       65       -2
Impacted Files Coverage Δ
src/krotov/optimize.py 97.64% <ø> (ø)
src/krotov/conversions.py 98.14% <100.00%> (+0.10%) :arrow_up:
src/krotov/objectives.py 97.28% <0.00%> (+0.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15c912b...80caf14. Read the comment docs.

zachmanson commented 4 years ago

I will test this out tomorrow and let you know what I think

goerz commented 4 years ago

Thanks! I added you as a collaborator with the ability to review (if I understood the settings on Github correctly).