search

qucontrol / krotov

Python implementation of Krotov's method for quantum optimal control
https://qucontrol.github.io/krotov
Other
70 stars 29 forks source link

Fix wrong co-states definition in one example #81

Closed Basilewitsch closed 3 years ago

Basilewitsch commented 3 years ago

Closes #80

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

goerz commented 3 years ago

Can you rebase on the current master?

codecov[bot] commented 3 years ago

Codecov Report

Merging #81 (2cf5c8f) into master (5cc0386) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #81   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files          13      13           
  Lines        1672    1672           
======================================
  Hits         1607    1607           
  Misses         65      65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cc0386...2cf5c8f. Read the comment docs.