Re-add eslint and prettier capabilities to the project

qudlaty / BloodAndBullets

2 stars 0 forks source link

Re-add eslint and prettier capabilities to the project #136

Closed sEver closed 9 months ago

sEver commented 9 months ago

Steps executed to figure out what is needed:

Took a look at .prettierrc file and the commit in which it was added: Configure eslint and prettier, together with .eslintrc.json.
Searched for eslint in the repo history and took a look at the commits within the result: https://github.com/search?q=repo%3Aqudlaty%2FBloodAndBullets+eslint&type=commits
Found Add prettier and eslint commit, and going to recreate what's inside of it.

sEver commented 9 months ago

This was only the beginning. Turns out, our eslint config was never enhanced to truly handle typescript. After enhancing it with react and typescript plugins, we discovered our codebase triggers hundreds of lint errors.

We've disabled some rules to make the codebase pass linting, it's going to be a process to correct and review all the issues.

sEver commented 9 months ago

Merged the PR enabling some rulesets and having all the codebase linted and corrected.