qudt / qudt-public-repo

QUDT -Quantities, Units, Dimensions and dataTypes - public repository
Other
118 stars 75 forks source link

NVS P06 units that are missing from QUDT #268

Closed dr-shorthair closed 3 years ago

dr-shorthair commented 4 years ago

This list attached here https://github.com/qudt/qudt-public-repo/issues/268#issuecomment-721424132 shows items from the NERC Vocabulary Service P06 vocabulary which do not have matches in QUDT, but could do since the elements are already there:

Also see https://github.com/nvs-vocabs/P06/issues/18

@gwemon

dr-shorthair commented 4 years ago

Here they are with Dimension vectors and conversion-multipliers

qudt-requests.xlsx (see below)

@gwemon Progress!

dr-shorthair commented 4 years ago

@steveraysteveray I think this is minimum info needed for some new Units ?

  1. a little unsure about some of the dimension vectors that involve dimensionless quanties
  2. I did the conversions as multipliers, but in some cases (mostly around time) it might be better to use coefficients?

What is the best way to progress these? I didn't want to make each one a separate issue/PR - that would be ridiculous. Note that these units are all currently in-use in oceanography datasets, so even though some of them look a bit strange and sometimes redundant, they are needed.

dr-shorthair commented 4 years ago

And now with Labels and Definitions taken directly from P06. I've added some QuantityKind entries, but many not available.

qudt-requests.xlsx (see below)

dr-shorthair commented 4 years ago

Updated to fix misunderstanding of D value in Dimension Vector - #270 qudt-requests.xlsx (see below)

steveraysteveray commented 4 years ago

Simon, Once we're less distracted with the future of democracy over here, I will be focusing on all your hard work so that we can add these units, and come to some agreement on the quantity/quantitykind question!

dr-shorthair commented 4 years ago

Added a couple more: qudt-requests.xlsx (see below)

For sure I did not expect these to be processed immediately. Just trying to make it as easy as possible for us to knit together the various systems ;-)

dr-shorthair commented 4 years ago

FYI recent additions to NVS P06 have added link to QUDT as a matter of course - https://github.com/nvs-vocabs/P06/issues/19 http://vocab.nerc.ac.uk/collection/P06/current/MGRM/

steveraysteveray commented 4 years ago

Wonderful!

dr-shorthair commented 4 years ago

A few corrections qudt-requests.xlsx (see below)

steveraysteveray commented 4 years ago

Simon, I did some hacking to bludgeon your spreadsheet above into triples that conform to our structure. 😄 However, along the way I see a few suspicious entries, such as BQ-SEC-PER-M3 having a QuantityKind of ActivityConcentration, since all the other units with that QuantityKind have a different dimensionality: image

So I invite you to take a look at the srr-P06-imports branch and let's quality-check it. Also, as you know from your spreadsheet, many of the units are missing QuantityKind values altogether.

dr-shorthair commented 4 years ago

The QuantityKind column is very dubious throughout. I just threw a few in where I thought I could find existing QKs that fit, but needs to be reviewed. Probably we should bring in @gwemon

That one is definitely incorrect - looks like it was mis-pasted and should be in the line above. Probably it should be AbsoluteActivity

qudt-requests.xlsx (see below)

gwemon commented 3 years ago

I'll have a look later on this week.

dr-shorthair commented 3 years ago

Suggest just working from the spreadsheet.

dr-shorthair commented 3 years ago

@steveraysteveray I converted the spreadsheet to SKOS-Play! format which makes it easy to generate TTL (not actually restricted to SKOS)-

Excel file - P06-additions-to-QUDT.xlsx

TTL file - P06-additions-to-QUDT.ttl

dr-shorthair commented 3 years ago

Files also in this fork https://github.com/dr-shorthair/qudt-public-repo/tree/P06/community/NVS-P06

This SKOS-Play! format seems pretty easy to work with. Might be a good general submission template?

steveraysteveray commented 3 years ago

Very interesting! About a week ago I discovered SHACL-Play, from the same people. https://shacl-play.sparna.fr/ I'll check out SKOS-Play.

dr-shorthair commented 3 years ago

Maybe not so much 'bludgeoning' required ;-)