search

qudt / qudt-public-repo

QUDT -Quantities, Units, Dimensions and dataTypes - public repository
Other
106 stars 69 forks source link

Clarification regarding Reflectance #757

Closed mgberg closed 9 months ago

mgberg commented 10 months ago

https://github.com/qudt/qudt-public-repo/blob/41c8507eb9ab97b8b8db7aebc9495619229b1747/vocab/quantitykinds/VOCAB_QUDT-QUANTITY-KINDS-ALL-v2.1.ttl#L17545-L17571

The above link highlights two quantity kinds currently defined:

  1. Reflectance, which according to the description is explicitly for sound power.
  2. Refectance, which according to the description is "fraction of incident electromagnetic power that is reflected at an interface".

The second URI and label (I think) is a typo, and the definition is consistent with reflectance as defined here which is the same page its qudt:informativeReference points to.

Assuming that is a typo, presumably the typo should be fixed- but how should that be resolved given the existing Reflectance?

steveraysteveray commented 10 months ago

Wow! What a great catch! I think there are two options:

  1. Mark Refectance as qudt:deprecated true, and broaden the definition and properties of Reflectance.
  2. Just delete Refectance, but still broaden the definition and properties of Reflectance.

Let's see what others think.

mgberg commented 10 months ago

@steveraysteveray Another option would be to deprecate or delete Refectance and replace it with a duplicate of it with a new URI such as ElectromagneticReflectance if it is desired to keep the two kinds of Reflectance separate.

mgberg commented 9 months ago

@steveraysteveray Any additional insights on this?

steveraysteveray commented 9 months ago

Yes, see #764. We just merged both definitions into Reflectance since Refectance was a misspelling. Pending review.

mgberg commented 9 months ago

Ah! I missed that, thanks!