qudt / qudt-public-repo

QUDT -Quantities, Units, Dimensions and dataTypes - public repository
Other
114 stars 71 forks source link

Added qudt:iec61360Code relation to QuantityKind #847

Closed steveraysteveray closed 8 months ago

jhodgesatmb commented 8 months ago

I added this property into the development branch for other work I was doing but how did it come to be needed on the main branch? Did I mess something up?

On Thu, Jan 11, 2024 at 1:00 PM QUDT @.***> wrote:

Merged #847 https://github.com/qudt/qudt-public-repo/pull/847 into main.

— Reply to this email directly, view it on GitHub https://github.com/qudt/qudt-public-repo/pull/847#event-11461538867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQRWNO2UOTWZBDKUNWKR3YOBHGXAVCNFSM6AAAAABBXD3QE6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3DCNJTHA4DMNY . You are receiving this because your review was requested.Message ID: @.***>

-- Jack

steveraysteveray commented 8 months ago

You are right. I did not check your development branch. I added it in anticipation of our quantity kinds having pointers to iec61360 codes. It shouldn't hurt that it's defined in both branches, and should merge fine when the time comes.

jhodgesatmb commented 8 months ago

If you need examples there are many QuantityKinds in the dev branch with iec61360Code values.

On Fri, Jan 12, 2024 at 7:19 AM steveraysteveray @.***> wrote:

You are right. I did not check your development branch. I added it in anticipation of our quantity kinds having pointers to iec61360 codes. It shouldn't hurt that it's defined in both branches, and should merge fine when the time comes.

— Reply to this email directly, view it on GitHub https://github.com/qudt/qudt-public-repo/pull/847#issuecomment-1889493777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQRWKSKBROFMDNQFA3OUTYOFIAZAVCNFSM6AAAAABBXD3QE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGQ4TGNZXG4 . You are receiving this because your review was requested.Message ID: @.***>

-- Jack