search

qudt / qudt-public-repo

QUDT -Quantities, Units, Dimensions and dataTypes - public repository
Other
108 stars 69 forks source link

Add unit:R_man, fix conversionMultiplier of unit:MilliR_man #848

Closed fkleedorfer closed 5 months ago

jhodgesatmb commented 5 months ago

I may be losing my marbles but I thought that our qualifiers were not lower case. I should look through the catalog. Maybe I am mistaken.

On Fri, Jan 12, 2024 at 7:16 AM steveraysteveray @.***> wrote:

Merged #848 https://github.com/qudt/qudt-public-repo/pull/848 into main.

— Reply to this email directly, view it on GitHub https://github.com/qudt/qudt-public-repo/pull/848#event-11470489607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQRWOXA3FTHYUSLOGF433YOFHWJAVCNFSM6AAAAABBX5J5BOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3TANBYHE3DANY . You are receiving this because your review was requested.Message ID: @.***>

-- Jack

steveraysteveray commented 5 months ago

We haven't taken a position on the case of qualifiers. Sometimes they are all uppercase (_US, _H2O), sometimes TitleCase (_Stat, _Ab), sometimes lowercase (_man). One could argue _man should be _Man, but @fkleedorfer was following our existing MilliR_man unit when defining R_man. We could think about deprecating and renaming...

(unit:TON is especially exciting: TON_LONG, TON_SHORT, TON_Metric, TON_US, TON_UK, TON_Assay...)

jhodgesatmb commented 5 months ago

The naming convention needs to be consistent, defined, and documented. I could see either UP or TC but not LC.

On Fri, Jan 12, 2024 at 8:47 AM steveraysteveray @.***> wrote:

We haven't taken a position on the case of qualifiers. Sometimes they are all uppercase (_US, _H2O), sometimes TitleCase (_Stat, _Ab), sometimes lowercase (_man). One could argue _man should be _Man, but @fkleedorfer https://github.com/fkleedorfer was following our existing MilliR_man unit when defining R_man. We could think about deprecating and renaming...

(unit:TON is especially exciting: TON_LONG, TON_SHORT, TON_Metric, TON_US, TON_UK, TON_Assay...)

— Reply to this email directly, view it on GitHub https://github.com/qudt/qudt-public-repo/pull/848#issuecomment-1889632367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQRWLJXLRZCXHSFLX3CZDYOFSKHAVCNFSM6AAAAABBX5J5BOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGYZTEMZWG4 . You are receiving this because your review was requested.Message ID: @.***>

-- Jack