Copied over the harmonization files

steveraysteveray commented 5 months ago

@fkleedorfer, would you be willing to run your conversion multiplier generator code on this branch? It contains a significant number of new units that lack conversion multipliers. Feel free to add an additional commit to this branch directly.

Thanks in advance!

fkleedorfer commented 5 months ago

I did the conversionMultiplier generation, please cross-check.

Of special note:

the commit contains some corrections of (presumably) wrong conversion multipliers. However, the original multipliers have not been removed. Someone needs to cross check the corrections and remove whichever one is actually wrong.
~~many corrections concern units derived from 'BIT' or 'BYTE' - I am especially unsure about those. Please double check!~~ (EDIT: filtered those out)
If you can provide more information (specifically: dimension vector and conversion multiplier) for
- unit:GAL2_US
- unit:GAL2_UK
- unit:A_Reactive
- unit:OCTET ... we can come up with the multiplier.

UPDATE: I reverted that commit as I found some errors. Will re-commit soon.

steveraysteveray commented 5 months ago

@fkleedorfer, thanks so much for your rapid response! Let me address some of the issues you observed:

. vs 'pt' vs 'dot'. The QUDT Board recently revisited this topic, because all of the encodings currently exist at times. We agreed to go with 'dot' instead of '.' in all the URIs where it shows up. (So, FT_H2O_39dot2DEG_F)
We have still not discussed and agreed on your suggestion in #815, so please stay tuned on that.
We are trying to stick with the decimal . in places where you have found a , so yes, please feel free to fix those. (qudt:symbol "ftH₂O (39.2 ºF)" ;
Regarding the units derived from BIT and BYTE, we defined the conversion multiplier of unit:BIT in terms of unit:NAT, which is the unit of information entropy based on natural logarithms, consistent with thermodynamic entropy. So we should double-check all the derived units building on BIT and BYTE for consistency with this.
Regarding GAL2_US, that means square US gallons. Not sure what the ambiguity is here.

If you would like, we could divide up the tasks. Let me know which ones do not easily automate for you and I will pick those up. We can continue in this branch.

Thanks again.

fkleedorfer commented 5 months ago

@fkleedorfer, thanks so much for your rapid response! Let me address some of the issues you observed:
1. . vs 'pt' vs 'dot'.   The QUDT Board recently revisited this topic, because all of the encodings currently exist at times. We agreed to go with 'dot' instead of '.' in all the URIs where it shows up. (So, FT_H2O_39dot2DEG_F)

Just ran a search, there will be lots of changes. I'll just touch the one that bit me.

2. We have still not discussed and agreed on your suggestion in [Change request to avoid ambiguous use of hyphen introduced in 2.1.30 #815](https://github.com/qudt/qudt-public-repo/issues/815), so please stay tuned on that.

Understood, no worries. Sorry again for making a fuss after the fact.

3. We are trying to stick with the decimal . in places where you have found a ,  so yes, please feel free to fix those. (qudt:symbol "ftH₂O (39.2 ºF)" ;

ok, will do.

4. Regarding the units derived from BIT and BYTE, we defined the conversion multiplier of unit:BIT in terms of unit:NAT, which is the unit of information entropy based on natural logarithms, consistent with thermodynamic entropy. So we should double-check all the derived units building on BIT and BYTE for consistency with this.

ok, then I'll add those corrections again and we can revisit.

5. Regarding GAL2_US, that means square US gallons. Not sure what the ambiguity is here.

oh, then it's a mistake, I believe - it should be unit:GAL_US2 and unit:GAL_UK2. Unless you protest, I'll change it

If you would like, we could divide up the tasks. Let me know which ones do not easily automate for you and I will pick those up. We can continue in this branch.

Let me just finish the points I noted above (unless you have objections) in this branch (1hr from now I estimate).

steveraysteveray commented 5 months ago

I don't see so many occurrences in the URIs, but we can dig deeper after your pass.
Agreed
Agreed
Agreed
Agreed

steveraysteveray commented 5 months ago

I have checked all the erroneous conversion multipliers, and you are of course correct!

fkleedorfer commented 5 months ago

I've done all I promised. Have you checked the multipliers from the last commit and the dimension vectors as well?

fkleedorfer commented 5 months ago

Done for the day. What's left to do is to verify the dimension vector corrections, delete all the wrong qudt:hasDimensionVector triples and adapt the quantitykinds, possibly creating new dim vector entities as well.

If you want to chip in, that's most welcome!

steveraysteveray commented 5 months ago

I'm working on checking the incorrect dimension vectors and added some of relevant quantity kinds when it seemed to make sense. I did not change any of the incorrect dimension vectors, so this still needs to be done.

Progress so far:

The GigaFLOPS-PER-SEC and related units are just wrong and should not exist with -PER-SEC. I have removed those units. (Similar to the common phrase "ATM Machine" where ATM already means "Automated Teller Machine"!)

(Incidentally, in your code, the supporting comment line seemed wrong in this case: # factor unit tree for unit g/(cm³.bar). The cm³ should have been just cm, but the calculations are still correct.)

steveraysteveray commented 5 months ago

@fkleedorfer, I believe I have now deleted the incorrect, and added the corrected, dimension vectors, along with adding the corrected conversion multipliers (since you had already deleted the incorrect ones). It would be good if you could run your routines once more to ensure nothing slipped through.

Other than that, when I run my validator, I get only 2 kinds of errors:

Some quantity kinds that are missing dimension vectors (which will be a manual process)
Some units that are missing quantity kinds (also a manual process)

fkleedorfer commented 4 months ago

Ran the conversion multiplier checks again, came up with some more corrections/additions (after some refactoring of the code). sorry for that.

fkleedorfer commented 4 months ago

Also I found unit:PER-MILLE-PER-PSI, which does not conform to the convention. I deprecated it in favor of new unit:PER-MILLE-PSI. Hope that's correct and ok

fkleedorfer commented 4 months ago

I added symbols and ucum codes. I know it's a lot, so if you don't want them, just remove the commits.

I think I am done. Let me know if you need anything else.

fkleedorfer commented 4 months ago

Re-did the symbols/ucum codes. Looks better now.

jhodgesatmb commented 4 months ago

I do not see anything to review anymore for #855.

On Mon, Feb 26, 2024 at 8:39 AM QUDT @.***> wrote:

Merged #855 https://github.com/qudt/qudt-public-repo/pull/855 into main.

— Reply to this email directly, view it on GitHub https://github.com/qudt/qudt-public-repo/pull/855#event-11924218803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATQRWPHUSQDCEXCWV4JA53YVS3DDAVCNFSM6AAAAABCRYYQSKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEZDIMRRHA4DAMY . You are receiving this because your review was requested.Message ID: @.***>

-- Jack

steveraysteveray commented 4 months ago

Correct. The publication script is running as we speak.

qudt / qudt-public-repo

Copied over the harmonization files #855