update rdfs:label for M3-PER-MOL-SEC

qudt / qudt-public-repo

QUDT -Quantities, Units, Dimensions and dataTypes - public repository

Other

113 stars 71 forks source link

update rdfs:label for M3-PER-MOL-SEC #912

Closed berrisfordjohn closed 5 months ago

berrisfordjohn commented 5 months ago

The rdfs:label for M3-PER-MOL-SEC references centimeters instead of meters

Suggested change from rdfs:label "Cubic Centimeter per Mole Second"@en ; rdfs:label "Cubic Centimeter per Mole Second"@en-us ;

to rdfs:label "Cubic Metre per Mole Second"@en ; rdfs:label "Cubic Meter per Mole Second"@en-us ;

i.e.

I did try to create a pull request but I don't seem have to write access to create a branch (understandable).

steveraysteveray commented 5 months ago

I appreciate your deep digging into QUDT! I'm afraid some of the more "cosmetic" parts (like the labels) do indeed need more scrutiny, so this is great. As far as write access, we are urging contributors to use a fork for changes (described here)

berrisfordjohn commented 5 months ago

Hi No problem at all. I'm happy to raise pull requests for these issues - for some reason i wasn't able to make a branch in the repo (I suspect the issue is at my end). If i can work this out I'll raise pull requests.

As to how I'm spotting these issues - I've extracted the data from qudt and then systematically looking for duplicate labels for different qudt units

steveraysteveray commented 5 months ago

You got my curiousity going, and I have found 27 distinct units that share the same IEC 61360 code and are not intentionally dual entries (i.e. either via deprecation, or where they share qudt:exactMatch).

fkleedorfer commented 5 months ago

I'm happy to raise pull requests for these issues - for some reason i wasn't able to make a branch in the repo (I suspect the issue is at my end). If i can work this out I'll raise pull requests.

You need to fork the repository, then commit changes to your fork, then you can make a PR.

berrisfordjohn commented 5 months ago