search

queen-raae / gatsby-remark-oembed

A GatsbyJS Plugin that transforms oembed links into its corresponding embed code.
https://gatsby-remark-oembed.netlify.com/
MIT License
162 stars 25 forks source link

Unfurl links that don't have oEmbed provider #100

Open anindha opened 4 years ago

anindha commented 4 years ago

I want to replicate the behaviour of Slack or Twitter where all links are transformed into either embeded content or link previews.

I want to merge some of the logic from gatsby-remark-link-unfurl.

Please let me know what you think.

raae commented 4 years ago

That sounds awesome!

It could maybe also be a choice for each provider what to do, maybe for YouTube you do want the embed. But for Twitter, you would like to turn it off and use the unfurl approach instead.

anindha commented 4 years ago

@raae I put up a POC that works for the base case. Your suggestion for having it configurable for each url is a good one. I'll have a think how to do that. Please let me know if you have any comments. I am still not sure the best way to style the preview card.

raae commented 4 years ago

I was thinking per provider. In the same way we have for other provider specific settings. I have a lot going right now, but will try to have a look at your POC before the end of the week.