search

queen-raae / gatsby-remark-oembed

A GatsbyJS Plugin that transforms oembed links into its corresponding embed code.
https://gatsby-remark-oembed.netlify.com/
MIT License
162 stars 25 forks source link

throw errors when trying to use instagram but don't provide a token #112

Closed JipSterk closed 4 years ago

JipSterk commented 4 years ago

Implements #111

raae commented 4 years ago

I am forgetting how my own codes work and have not have time for a through look through the code. But I am thinking this might throw if one has no instagram links and no settings.

raae commented 4 years ago

Also thank you so much for contributing. I was a little tired this morning and forgot to be polite.

JipSterk commented 4 years ago

hi @raae its okay. we all get tired time to time its totally okay 🌈. i've never done anything with gatsby, but this would seem as a great plugin for a blog! also was very surprised with the amount of integrations currently. keep going and most importantly stay safe & stay sane ❤️

raae commented 4 years ago

@nickytonline did a "yarn format" on the project, if you could do that as well and I will approve.

raae commented 4 years ago

Seems we need to work on that formatting @nickytonline, not sure what is happening here.

nickytonline commented 4 years ago

@JipSterk, can you merge latest of master into your branch? It should contain all the updated formatting changes from prettier. I ran prettier on the entire code base in a previously merged PR.

Also @raae, I ran prettier directly on all the files in the code base. I wasn't aware you had a format command.

nickytonline commented 4 years ago

Hmm, it looks like when I ran prettier it resulted in different formatting than npm run format and I just discovered that npm run format does not actually change the files, it only outputs them. The issue is related to an extraneous --. Let me fix that up and then if you merge latest of master, it should all be good.

raae commented 4 years ago

I am sorry things are a little messy @JipSterk, I have marked this PR as hacktoberfest accepted in case you are participating in that and we do not get this closed by Sunday ;)

nickytonline commented 4 years ago

@JipSterk, thanks again for the PR.👏

If you merge latest from master, there should no longer be conflicts. If you have any issues doing this on your local,let me know and I can help sort it out.

raae-bot commented 2 years ago

:tada: This PR is included in version 0.2.0-next.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

raae-bot commented 2 years ago

:tada: This PR is included in version 0.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: