search

queen-raae / gatsby-remark-oembed

A GatsbyJS Plugin that transforms oembed links into its corresponding embed code.
https://gatsby-remark-oembed.netlify.com/
MIT License
162 stars 25 forks source link

Create pull_request_template.md #138

Closed gunesnt closed 2 years ago

gunesnt commented 4 years ago

Adds a pull request template to the project.

raae commented 4 years ago

I really like this, what do you think @nickytonline?

gunesnt commented 4 years ago

@gunesnt, thanks so much for the PR! This will definitely help out future contributors when contributing to the repository.

I have some comments/feedback. @raae, if you could chime in as well. Thanks again and looking forward to seeing this get merged into the project!

Thank you very much. Should I make a new PR with these changes? or anything else?

nickytonline commented 4 years ago

I'll let @raee chime in and then we can go from there.

raae commented 4 years ago

I agree with @nickytonline, se inline comments.

There is no need for a new Pull Request, if you do the changes and push to your branch it should be reflected here.

Thank you again, so happy more people are joining in.

raae commented 3 years ago

Would you like to keep working on this @gunesnt?

nickytonline commented 2 years ago

Hi @gunesnt! Just following up one more time to see if you'd like to see this through. If not, no worries. If, not, it'll be a great starting point for another contributor.