queengooborg / PlusTiC-Reforged

A new iteration of the classic PlusTiC mod, updated for modern Minecraft versions
https://www.curseforge.com/minecraft/mc-mods/plustic-reforged
GNU General Public License v3.0
2 stars 0 forks source link

old plustic crash with ignoble #3

Closed Sulferix closed 2 months ago

Sulferix commented 2 months ago

simple, game can freeze when using a tool with ignoble on it. crash-2024-08-23_23.43.07-server.txt crash-2024-08-23_12.28.58-server.txt first crash is with this forked version of plustic, second crash is the old 8.0.3 og version.

queengooborg commented 2 months ago

I wasn't able to replicate the issue, though I've not used this trait before so I wouldn't be surprised if I'm using it wrong! I tried in both singleplayer and multiplayer (with just myself logged on; but I see in your crash log you were the only player online as well) and wasn't able to get my game to crash.

I did take a look at the code and noticed some bizarre things, so I'm hoping that 449648fe7a7861245f2d9f411662b0c7f7234159 fixes the issue.

Can you give the following custom version a try and see if the issue persists?

Sulferix commented 2 months ago

upon testing with that new version for a while, it seemed to have no issues. looks like you fixed it! nice response time, appreciate it.

queengooborg commented 2 months ago

Awesome, I'm happy to hear that it's all working and it was easily fixable!