search

queenkjuul / jekyll-98

Jekyll blog theme based on Windows 98 theme from XP.css
https://queenkjuul.github.io/jekyll-98/
MIT License
1 stars 0 forks source link

Clearing Default Social Media Links #2

Open cyberselkie opened 1 month ago

cyberselkie commented 1 month ago

Because there is a Twitch, Youtube, and Github set on the default config file, it displays on the theme regardless of whether it is set in the user's _config.yml or not.

queenkjuul commented 1 month ago

ah hmm I'll see about updating it, in the meantime, can you try setting those to blank, like github: and see if that removes it?

cyberselkie commented 1 month ago

It didn't work unfortunately, but I also want to say this is exactly what I've been looking for for ages and thank you for making it!

queenkjuul commented 1 month ago

Ok maybe try this:

github: ""

When i get a chance I'll try and figure out the right way to override the theme config

queenkjuul commented 1 month ago

And glad you like it 😊

queenkjuul commented 1 month ago

@cyberselkie sorry I didnt get back to this sooner - how are you implementing the site theme? Did you fork the site repo, or are you defining the theme via remote_theme: queenkjuul/jekyll-98 ? Also, deploying via GitHub Actions, the "deploy from branch", or something else?

Basically, I am unable reproduce the issue - this pages repo (deployed here) does not display any social links if there are no socials defined in the user _config.yaml

That repo uses the GitHub Action deployment method via remote_theme: queenkjuul/jekyll-98 in the _config.yaml

cyberselkie commented 1 month ago

I was installing it as a gem theme using the manual installation instructions, it's not on Github pages but hosted on Netlify.

queenkjuul commented 1 month ago

oh ok. I really have done next to zero testing on that method (my own website uses the theme as a submodule, not a gem, so I can develop the theme against my own site)

I can probably upload a new gem build that strips out all the config defaults? But other things, like the site title and your name and stuff, those get overridden by your own values, yes?

Are you defining some of your own social links, and the defaults are overriding the ones you've specified, or is it only when there's a default which isn't part of your own config?

cyberselkie commented 1 month ago

Only when there's a default that isn't part of my config, my own config overrides

queenkjuul commented 1 month ago

Got it, ok. I will rebuild the gem such that it ships with a clean config file which only populates required fields by default. I'll ping you when I get that done

queenkjuul commented 1 month ago

@cyberselkie well I just went ahead and did it now lol. v0.3.1 should now be available, try updating and let me know what happens