search

queenvictoria / ember-videojs

MIT License
5 stars 11 forks source link

sendAction is deprecated #4

Open eelke opened 6 years ago

eelke commented 6 years ago

Using the plugin with Ember 3.4+ yields a large number of warnings, as sendAction is deprecated. See https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action for more information.

queenvictoria commented 6 years ago

Great! Any chance of a pull request?

eelke commented 5 years ago

Hi @queenvictoria, sorry for the late reply. I spent a couple of hours trying to fix it, but I'm afraid I'm a bit at a loss. It seems any change I make immediately renders breaking changes to the addon, due to the way it's currently set up.

queenvictoria commented 5 years ago

Ok thanks for the research. I'll look in to it when I have a 3.4+ project. In the meantime lets leave this one open so that people are aware and might be able to resolve it.