Add proportional mob stack harvest drops and persist potion effects over mob stack kills

queer / box

A magical Minecraft box

GNU General Public License v3.0

7 stars 2 forks source link

Add proportional mob stack harvest drops and persist potion effects over mob stack kills #13

Closed broman closed 5 years ago

broman commented 5 years ago

Implements #2

I think I did this right. Literally of this code was produced between 12am and 2am and I took a page out of Sam's book and didn't test anything, so don't yell at me

broman commented 5 years ago

Natan pointed out the for loop should be 2 to component.count(le) so I will correct this as well as the reviews above when I get home

broman commented 5 years ago

Requested changes have been implemented

queer commented 5 years ago

@natanbc summoning you in here to make sure I'm not missing anything obvious

@broman Did you actually test it?

broman commented 5 years ago

@broman Did you actually test it?

Haha yes Am testing and currently fixing minor issues

broman commented 5 years ago

Since I can't work git properly this PR also implements #1