search

queerviolet / bones

MIT License
36 stars 119 forks source link

npm start script assumes nodemon is installed #12

Closed sbwheeler closed 7 years ago

sbwheeler commented 7 years ago

Ran into this issue when deploying a bones app to heroku. The npm start script uses nodemon, but nodemon is not listed in any of the npm dependencies, so bones is essentially assuming that nodemon is installed globally. If you don't install it locally, your npm start script will hit errors when deployed to heroku.

glebec commented 7 years ago

Yes, it would seem it should be added as a devDependency. EDIT: nodemon probably shouldn't be used in Heroku at all — doesn't it use its own process manager to enable restarts?

glebec commented 7 years ago

Turns out this was added to the dependencies list in https://github.com/queerviolet/bones/commit/5359b1343b0071a314b0761428f62f6d1e63f92f. This issue can therefore be closed. However I want to follow up on the issue of using nodemon in a Heroku app, so I will make that a separate issue.