search

queerviolet / bones

MIT License
36 stars 119 forks source link

Remove symlink from node_modules (only create from script) #27

Closed glebec closed 7 years ago

glebec commented 7 years ago

Right now the APP symlink is committed to node_modules.

There doesn't seem to be any real benefit to this except to demo how you can gitignore everything in a directory except certain files. The symlink is generated in the setup script if not found, and the setup script can easily be run from a postinstall (as it now does in various Bones forks).

Moreover, having git track node_modules can be annoying, as an rm -rf node_modules during development can theoretically result in spurious commits removing the APP symlink (only for it to be added back in later, after the setup script runs).

It's a fairly trivial change but I vote on removing the included symlink and sticking to the generated symlink. I am interested in possible counter-arguments however.

glebec commented 7 years ago

Note that this issue may be related to #14. We should test to ensure that removing the symlink does not break Heroku deployment.

glebec commented 7 years ago

This issue was moved to FullstackAcademy/bones#75